add headers to websocket connection#79
Merged
cbrady merged 2 commits intoMay 14, 2026
Merged
Conversation
bpapillon
reviewed
May 13, 2026
Contributor
bpapillon
left a comment
There was a problem hiding this comment.
This makes sense and looks good to me. My Claude sweep came up with this, which I have not tested and am not sure whether is valid or not:
- handshake.go — resolveClientVersion(): Because the replicator is the main module (not a dependency), info.Main.Version will be "(devel)" for go build . builds, which is what deployments/Dockerfile runs. The doc
comment claims "For tagged releases this returns the tag" but that only holds if a consumer runs go install github.com/schematichq/schematic-datastream-replicator@v1.2.3 — not the path CI/CD takes here. In
practice the X-Schematic-Client-Version header will report (devel) from every Docker build, undermining the ticket's "correlate them to a release" goal.
- The Dockerfile already passes a real version via -ldflags="-X main.version=${VERSION:-dev} ..." (Dockerfile line ~42), but main.go has no var version string to receive it — a pre-existing dead injection.
Consider declaring var version string (and commit, buildTime) in main.go and having resolveClientVersion() prefer it when set:
if version != "" {
return version
}
bpapillon
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.